Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ACA contract to support registryName instead of loginServer #3818

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Change ACA contract to support registryName instead of loginServer #3818

merged 2 commits into from
Jan 31, 2023

Conversation

MicroFish91
Copy link

@MicroFish91 MicroFish91 commented Jan 30, 2023 •
edited
Loading

See title.

Also reverted the Docker Hub registry path addition from my previous PR since we don't need it with this method

@MicroFish91 MicroFish91 marked this pull request as ready for review January 30, 2023 23:32
@MicroFish91 MicroFish91 requested a review from a team as a code owner January 30, 2023 23:32
@MicroFish91 MicroFish91 mentioned this pull request Jan 30, 2023
Merged
@bwateratmsft bwateratmsft merged commit 0b2fcf9 into bmw/acaDeploy Jan 31, 2023
@bwateratmsft bwateratmsft deleted the mwf/acaDeploy2 branch January 31, 2023 15:04
@microsoft microsoft locked and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bwateratmsft bwateratmsft bwateratmsft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MicroFish91 @bwateratmsft